Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INT-2227 chore: Migrate all pages in /video directory #136

Closed
wants to merge 9 commits into from
Closed

INT-2227 chore: Migrate all pages in /video directory #136

wants to merge 9 commits into from

Conversation

hbjORbj
Copy link

@hbjORbj hbjORbj commented Nov 30, 2023

No description provided.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 30, 2023 •
edited
Loading

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "INT-2227 chore: Migrate all pages in `/video` directory". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@hbjORbj hbjORbj changed the title chore: Migrate all pages in /video directory INT-2227 chore: Migrate all pages in /video directory Nov 30, 2023
@linear Linear
Copy link

linear bot commented Nov 30, 2023

INT-2227 Chunkify pages inside "/video"

DmytroHryshyn
DmytroHryshyn reviewed Nov 30, 2023
View reviewed changes
apps/web/app/future/(individual-page-wrapper)/video/[uid]/page.tsx Outdated
nonce={nonce}
themeBasis={null}
dehydratedState={props.dehydratedState}>
<OldPage {...props} trpcState={props.dehydratedState} />
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does OldPage use trpcState?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@DmytroHryshyn
Copy link

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@DmytroHryshyn DmytroHryshyn mentioned this pull request Dec 1, 2023
Merged
6 tasks
@hbjORbj hbjORbj force-pushed the 11-30-chore_Migrate_/teams_page branch 2 times, most recently from af5ef2a to 36e1b92 Compare December 1, 2023 18:09
@hbjORbj hbjORbj force-pushed the 11-30-intuita_codemod_app-directory-boilerplate-calcom branch from b0c9012 to b65f3c8 Compare December 1, 2023 18:16
@DmytroHryshyn DmytroHryshyn force-pushed the 11-30-intuita_codemod_app-directory-boilerplate-calcom branch from b65f3c8 to bd02be1 Compare December 11, 2023 18:50
@hbjORbj hbjORbj force-pushed the 11-30-chore_Migrate_/teams_page branch from f4540f7 to 663f517 Compare December 12, 2023 09:44
@hbjORbj hbjORbj force-pushed the 11-30-intuita_codemod_app-directory-boilerplate-calcom branch from bd02be1 to 65809e1 Compare December 12, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DmytroHryshyn DmytroHryshyn DmytroHryshyn approved these changes

Assignees
No one assigned
Labels
❗️ .env changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hbjORbj @DmytroHryshyn